Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup WORKSPACE and MODULE.bazel files #1673

Merged
merged 1 commit into from
Apr 22, 2024
Merged

chore: cleanup WORKSPACE and MODULE.bazel files #1673

merged 1 commit into from
Apr 22, 2024

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Apr 21, 2024 •
edited
Loading

Consistent formatting, structure & set dev_dependency = True everywhere it applies.

@gregmagolan gregmagolan requested a review from jbedard April 21, 2024 19:30
@gregmagolan gregmagolan force-pushed the rjs2_cleanup_deps branch 2 times, most recently from 72fce61 to 31907a3 Compare April 21, 2024 19:33
@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Apr 21, 2024 •
edited
Loading

Test

All tests were cache hits

189 tests (100.0%) were fully cached saving 57s.

Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 442ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 2s.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 6s.

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 857ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 2s.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 432ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 506ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

4 tests (100.0%) were fully cached saving 564ms.

Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 4s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 3s.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 899ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 221ms.

Buildifier      Format

@gregmagolan gregmagolan force-pushed the 2.x branch 2 times, most recently from df42327 to 91037dd Compare April 21, 2024 20:05
@gregmagolan gregmagolan force-pushed the rjs2_cleanup_deps branch 15 times, most recently from 15b1947 to 15f7949 Compare April 22, 2024 01:21
@gregmagolan gregmagolan requested a review from jbedard April 22, 2024 06:56
@jbedard jbedard requested a review from alexeagle April 22, 2024 15:19
@gregmagolan gregmagolan merged commit 498ca6a into 2.x Apr 22, 2024
102 checks passed
@gregmagolan gregmagolan deleted the rjs2_cleanup_deps branch April 22, 2024 22:48
gregmagolan added a commit that referenced this pull request Apr 22, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
ccc2132
gregmagolan added a commit that referenced this pull request Apr 23, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
4bacbc1
gregmagolan added a commit that referenced this pull request Apr 24, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
8c671b1
gregmagolan added a commit that referenced this pull request Apr 26, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
4b6038a
gregmagolan added a commit that referenced this pull request Apr 28, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
9dce5f2
gregmagolan added a commit that referenced this pull request Apr 28, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
2be6bd8
gregmagolan added a commit that referenced this pull request Apr 29, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
0775596
gregmagolan added a commit that referenced this pull request May 6, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
0ea8199
jbedard pushed a commit that referenced this pull request May 6, 2024
@gregmagolan @jbedard
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
f5ef569
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
a80ea05
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
f825d3c
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
ecc54fe
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
94a076c
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
a788e6c
jbedard pushed a commit that referenced this pull request May 8, 2024
@gregmagolan @jbedard
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
d5d5400
gregmagolan added a commit that referenced this pull request May 10, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
ff73c85
gregmagolan added a commit that referenced this pull request May 10, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
93189e0
@gregmagolan gregmagolan mentioned this pull request May 10, 2024
Merged
gregmagolan added a commit that referenced this pull request May 13, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
f142ef1
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 14, 2024
@gregmagolan @jbedard
chore: cleanup WORKSPACE and MODULE.bazel files (aspect-build#1673)
b0c7923
jbedard pushed a commit that referenced this pull request May 14, 2024
@gregmagolan @jbedard
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
0164e62
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 16, 2024
@gregmagolan @jbedard
chore: cleanup WORKSPACE and MODULE.bazel files (aspect-build#1673)
66b6fa8
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
22736b9
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
chore: cleanup WORKSPACE and MODULE.bazel files (#1673)
99275cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard approved these changes

@alexeagle alexeagle Awaiting requested review from alexeagle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregmagolan @jbedard