Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove legacy update_pnpm_lock default value #1624

Merged
merged 1 commit into from
Apr 8, 2024
Merged

refactor: remove legacy update_pnpm_lock default value #1624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/npm_translate_lock.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 1 addition & 6 deletions npm/private/npm_translate_lock.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def npm_translate_lock(
pnpm_lock = None,
npm_package_lock = None,
yarn_lock = None,
update_pnpm_lock = None,
update_pnpm_lock = False,
node_toolchain_prefix = "nodejs",
yq_toolchain_prefix = "yq",
preupdate = [],
Expand Down Expand Up @@ -618,11 +618,6 @@ def npm_translate_lock(
for value_key, value_value in value.items():
bins_string_list_dict[key].append("{}={}".format(value_key, value_value))

# Default update_pnpm_lock to True if npm_package_lock or yarn_lock is set to
# preserve pre-update_pnpm_lock `pnpm import` behavior.
if update_pnpm_lock == None and (npm_package_lock or yarn_lock):
update_pnpm_lock = True

if not update_pnpm_lock and preupdate:
fail("expected update_pnpm_lock to be True when preupdate are specified")

Expand Down
Loading