chore: change all internal virtual store naming to package store #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
approved these changes
Apr 7, 2024
jbedard
pushed a commit
that referenced
this pull request
Apr 9, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 9, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 13, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 13, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 15, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 19, 2024
jbedard
pushed a commit
that referenced
this pull request
Apr 19, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 20, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 21, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 21, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 22, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 23, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 24, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 26, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 28, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 28, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 29, 2024
gregmagolan
added a commit
that referenced
this pull request
May 6, 2024
jbedard
pushed a commit
that referenced
this pull request
May 6, 2024
gregmagolan
added a commit
that referenced
this pull request
May 7, 2024
gregmagolan
added a commit
that referenced
this pull request
May 7, 2024
gregmagolan
added a commit
that referenced
this pull request
May 7, 2024
jbedard
pushed a commit
that referenced
this pull request
May 8, 2024
gregmagolan
added a commit
that referenced
this pull request
May 10, 2024
gregmagolan
added a commit
that referenced
this pull request
May 10, 2024
gregmagolan
added a commit
that referenced
this pull request
May 13, 2024
jbedard
pushed a commit
to jbedard/rules_js
that referenced
this pull request
May 14, 2024
jbedard
pushed a commit
that referenced
this pull request
May 14, 2024
jbedard
pushed a commit
to jbedard/rules_js
that referenced
this pull request
May 16, 2024
gregmagolan
added a commit
that referenced
this pull request
May 20, 2024
gregmagolan
added a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term "virtual store" comes from pnpm because the
node_modules/.pnpmfolder is full of hard-links to the actual pnpm package store which is managed elsewhere. Under rules_js,node_modules/.aspect_rules_jsis populated with actual files and not hard-links so we should simply refer to it as the "package store".All the renames in this PR are internal. No public API is affected.