test: add node20 toolchain tests #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
node20-sandbox-issue
branch
from
1b36500 to
688180f
Compare
jbedard
changed the title
jbedard
force-pushed
the
node20-sandbox-issue
branch
from
688180f to
3af0f3a
Compare
jbedard
force-pushed
the
node20-sandbox-issue
branch
from
3af0f3a to
e945b45
Compare
jbedard
requested review from
gregmagolan and
alexeagle
and removed request for
gregmagolan
thesayyn
approved these changes
Mar 13, 2024
|
I was looking into the fs patches for newer versions of node (21+) and figured we should at least add the LTS node versions for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't recall what originally prompted adding node v20 tests, but we probably should have basic node20 tests since it is LTS now.