Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update rules_nodejs to v6.0.5 for tests #1496

Merged
merged 1 commit into from
Feb 27, 2024
+28 −5
Merged

build: update rules_nodejs to v6.0.5 for tests #1496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,17 @@ bazel_dep(name = "aspect_bazel_lib", version = "1.40.0")
bazel_dep(name = "aspect_rules_lint", version = "0.9.1")
bazel_dep(name = "bazel_features", version = "0.1.0")
bazel_dep(name = "bazel_skylib", version = "1.5.0")

# Keep v5 in to avoid breaking changes.
# TODO(2.0): change minimum to v6
bazel_dep(name = "rules_nodejs", version = "5.8.2")

# Override rules_nodejs to v6 to test the latest and recommended version internally.
single_version_override(
module_name = "rules_nodejs",
version = "6.0.5",
)

bazel_dep(name = "platforms", version = "0.0.5")

node = use_extension("@rules_nodejs//nodejs:extensions.bzl", "node")
Expand Down
12 changes: 12 additions & 0 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,18 @@ workspace(
name = "aspect_rules_js",
)

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

# Override rules_nodejs to v6 to test the latest and recommended versional internally,
# while keeping v5 in rules_js_dependencies() to avoid breaking changes.
# TODO(2.0): change minimum to v6 in repositories.bzl
http_archive(
name = "rules_nodejs",
sha256 = "a50986c7d2f2dc43a5b9b81a6245fd89bdc4866f1d5e316d9cef2782dd859292",
strip_prefix = "rules_nodejs-6.0.5",
url = "https://github.com/bazelbuild/rules_nodejs/releases/download/v6.0.5/rules_nodejs-v6.0.5.tar.gz",
)

load("//js:dev_repositories.bzl", "rules_js_dev_dependencies")

rules_js_dev_dependencies()
Expand Down
2 changes: 1 addition & 1 deletion e2e/pnpm_repo_install/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module(
compatibility_level = 1,
)

bazel_dep(name = "rules_nodejs", version = "5.8.2")
bazel_dep(name = "rules_nodejs", version = "6.0.5")
bazel_dep(name = "aspect_rules_js", version = "0.0.0")
local_path_override(
module_name = "aspect_rules_js",
Expand Down
2 changes: 1 addition & 1 deletion e2e/pnpm_workspace/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module(
)

bazel_dep(name = "bazel_skylib", version = "1.4.1")
bazel_dep(name = "rules_nodejs", version = "5.8.2")
bazel_dep(name = "rules_nodejs", version = "6.0.5")
bazel_dep(name = "aspect_bazel_lib", version = "2.2.0")
bazel_dep(name = "aspect_rules_js", version = "0.0.0")
local_path_override(
Expand Down
2 changes: 1 addition & 1 deletion e2e/pnpm_workspace_rerooted/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module(
compatibility_level = 1,
)

bazel_dep(name = "rules_nodejs", version = "5.8.2")
bazel_dep(name = "rules_nodejs", version = "6.0.5")
bazel_dep(name = "aspect_bazel_lib", version = "1.40.0")
bazel_dep(name = "aspect_rules_js", version = "0.0.0")
local_path_override(
Expand Down
2 changes: 1 addition & 1 deletion e2e/vendored_node/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module(

bazel_dep(name = "aspect_bazel_lib", version = "1.40.0")
bazel_dep(name = "aspect_rules_js", version = "0.0.0")
bazel_dep(name = "rules_nodejs", version = "5.8.2")
bazel_dep(name = "rules_nodejs", version = "6.0.5")
bazel_dep(name = "platforms", version = "0.0.4")

local_path_override(
Expand Down
2 changes: 1 addition & 1 deletion e2e/worker/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module(
compatibility_level = 1,
)

bazel_dep(name = "rules_nodejs", version = "5.8.2")
bazel_dep(name = "rules_nodejs", version = "6.0.5")
bazel_dep(name = "aspect_rules_js", version = "0.0.0")
local_path_override(
module_name = "aspect_rules_js",
Expand Down
1 change: 1 addition & 0 deletions js/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ def rules_js_dependencies():
urls = ["https://github.com/bazelbuild/bazel-skylib/releases/download/1.4.1/bazel-skylib-1.4.1.tar.gz"],
)

# TODO(2.0): update to rules_nodejs v6
http_archive(
name = "rules_nodejs",
sha256 = "8fc8e300cb67b89ceebd5b8ba6896ff273c84f6099fc88d23f24e7102319d8fd",
Expand Down
Loading