Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move patch tests to e2e/verify-patches #1401

Merged
merged 1 commit into from
Jan 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -168,12 +168,8 @@ npm.npm_translate_lock(
},
patch_args = {
"*": ["-p1"],
"@gregmagolan/test-a": ["-p4"],
},
patches = {
"@gregmagolan/test-a": ["//examples/npm_deps:patches/test-a.patch"],
"@gregmagolan/test-a@0.0.1": ["//examples/npm_deps:patches/test-a@0.0.1.patch"],
"@gregmagolan/test-b": ["//examples/npm_deps:patches/test-b.patch"],
"meaning-of-life@1.0.0": ["//examples/npm_deps:patches/meaning-of-life@1.0.0-after_pnpm.patch"],
},
pnpm_lock = "//:pnpm-lock.yaml",
Expand Down
4 changes: 0 additions & 4 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -145,12 +145,8 @@ npm_translate_lock(
},
patch_args = {
"*": ["-p1"],
"@gregmagolan/test-a": ["-p4"],
},
patches = {
"@gregmagolan/test-a": ["//examples/npm_deps:patches/test-a.patch"],
"@gregmagolan/test-a@0.0.1": ["//examples/npm_deps:patches/test-a@0.0.1.patch"],
"@gregmagolan/test-b": ["//examples/npm_deps:patches/test-b.patch"],
"meaning-of-life@1.0.0": ["//examples/npm_deps:patches/meaning-of-life@1.0.0-after_pnpm.patch"],
},
pnpm_lock = "//:pnpm-lock.yaml",
Expand Down
3 changes: 0 additions & 3 deletions examples/npm_deps/patches/patches
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
examples/npm_deps/patches/meaning-of-life@1.0.0-after_pnpm.patch
examples/npm_deps/patches/meaning-of-life@1.0.0-pnpm.patch
examples/npm_deps/patches/test-a.patch
examples/npm_deps/patches/test-a@0.0.1.patch
examples/npm_deps/patches/test-b.patch
5 changes: 0 additions & 5 deletions examples/npm_deps/patches/test-a.patch

This file was deleted.

6 changes: 0 additions & 6 deletions examples/npm_deps/patches/test-a@0.0.1.patch

This file was deleted.

5 changes: 0 additions & 5 deletions examples/npm_deps/patches/test-b.patch

This file was deleted.

4 changes: 0 additions & 4 deletions npm/private/test/repositories_checked.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -1743,8 +1743,6 @@ def npm_repositories():
transitive_closure = {
"@gregmagolan/test-a": ["0.0.1"],
},
patches = ["@//examples/npm_deps:patches/test-a.patch", "@//examples/npm_deps:patches/test-a@0.0.1.patch"],
patch_args = ["-p4"],
)

npm_import(
Expand All @@ -1769,8 +1767,6 @@ def npm_repositories():
"@gregmagolan/test-a": ["0.0.1"],
"@gregmagolan/test-b": ["0.0.2"],
},
patches = ["@//examples/npm_deps:patches/test-b.patch"],
patch_args = ["-p1"],
)

npm_import(
Expand Down
Loading