chore: switch from Engflow to Buildbuddy #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
reviewed
Aug 28, 2023
alexeagle
added a commit
to aspect-build/rules_ts
that referenced
this pull request
Aug 28, 2023
alexeagle
added a commit
to aspect-build/rules_ts
that referenced
this pull request
Aug 30, 2023
* chore: switch rbe to buildbuddy Matches aspect-build/rules_js#1241 * fix: workaround aspect-cli issue with 'common' * chore: buildifier * chore: align buildifier version So that pre-commit and buildifier.check agree * fix: ts_proto_library must return runfiles too * chore: exclude rbe+e2e/bzlmod * Update .bazelrc.common * restore deleted file * chore: add missing TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Engflow cluster seems to be down, all RBE builds have been red since last week.
Taking this opportunity to delete Engflow-related TODOs as well - it seems Buildbuddy correctly allows remote actions to use the network for example.