Green up CI on main #1230
Merged
Green up CI on main #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
approved these changes
Aug 24, 2023
|
Oof! Thanks for letting me know @alexeagle. Let's chat on #1233 |
alexeagle
added a commit
that referenced
this pull request
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow #1210 broke the RBE test on the main branch. Sadly we were not running RBE from PRs, unless "rbe" appears as a substring of the branch name the PR originates from.
We need to revert this to push a working release again. FYI @gregjacobs let's work together to roll-forward again from a branch with "rbe" in the name (or, perhaps we should always test PRs with at least one RBE job, #1231 for example)