Add js_run_devserver_internal to keep original js_run_devserver API t…

…he same

js/private/js_run_devserver.bzl

@@ -110,12 +110,6 @@ _js_run_devserver = rule(
 
 def js_run_devserver(
         name,
-        tool = None,
-        command = None,
-        grant_sandbox_write_permissions = False,
-        use_execroot_entry_point = True,
-        allow_execroot_entry_point_with_no_copy_data_to_bin = False,
-        js_run_devserver_rule = _js_run_devserver,
         **kwargs):
     """Runs a devserver via binary target or command.
 
@@ -241,10 +235,26 @@ def js_run_devserver(
 
             See https://docs.aspect.build/rules/aspect_rules_js/docs/js_binary
     """
+    js_run_devserver_internal(
+        name,
+        rule_to_execute = _js_run_devserver,
+        **kwargs,
+    )
+
+def js_run_devserver_internal(
+        name,
+        rule_to_execute,
+        tool = None,
+        command = None,
+        grant_sandbox_write_permissions = False,
+        use_execroot_entry_point = True,
+        allow_execroot_entry_point_with_no_copy_data_to_bin = False,
+        **kwargs):
+
     if kwargs.get("entry_point", None):
         fail("`entry_point` is set implicitly by `js_run_devserver` and cannot be overridden.")
 
-    js_run_devserver_rule(
+    rule_to_execute(
         name = name,
         enable_runfiles = select({
             "@aspect_rules_js//js:enable_runfiles": True,

js/private/test/js_run_devserver/BUILD

@@ -3,17 +3,16 @@ load(":js_run_devserver_test.bzl", "js_run_devserver_test")
 
 npm_link_all_packages(name = "node_modules")
 
-# Test that bundlers see a single node_modules tree.
-# https://github.com/aspect-build/rules_js/issues/1204
 js_run_devserver_test(
     name = "js_run_devserver_test",
+    args = ["*.spec.mjs"],
     chdir = "js/private/test/js_run_devserver",
     command = "./node_modules/.bin/jasmine",
-    args = ["*.spec.mjs"],
     data = glob(["*.spec.mjs"]) + [
-        # Some packages to link back to the exec root for the tests (and need jasmine anyway)
+        # Some packages to link back to the exec root for the tests for
+        # https://github.com/aspect-build/rules_js/issues/1204 (and need jasmine
+        # anyway for the runner)
         ":node_modules/@types/node",
         ":node_modules/jasmine",
     ],
 )
-

js/private/test/js_run_devserver/js_run_devserver_test.bzl

@@ -1,4 +1,4 @@
-load("//js/private:js_run_devserver.bzl", "js_run_devserver", "js_run_devserver_lib")
+load("//js/private:js_run_devserver.bzl", "js_run_devserver_internal", "js_run_devserver_lib")
 
 # 'test' version of the _js_run_devserver` rule
 _js_run_devserver_test = rule(
@@ -26,9 +26,9 @@ def js_run_devserver_test(
 
             See https://docs.aspect.build/rules/aspect_rules_js/docs/js_run_devserver
     """
-    js_run_devserver(
+    js_run_devserver_internal(
         name,
-        js_run_devserver_rule = _js_run_devserver_test,
+        rule_to_execute = _js_run_devserver_test,
         # 'no-sandbox' needed to simulate 'bazel run' command - normally tests 
         # are sandboxed, but sandboxing doesn't exhibit the issue in 
         # https://github.com/aspect-build/rules_js/issues/1204