Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update old pnpm versions, improve jq script #1083

Merged
merged 1 commit into from
May 31, 2023

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented May 24, 2023

We update the jq command to sort them by version (and not release date). This is important to keep latest on the same major version (and not flap between 7 / 8).

Triggered by pnpm/pnpm#6424

Testing:

  • jq command tested manually
  • pnpm covered by existing test cases (e.g. e2e/js_run_devserver)

@gzm0
Copy link
Contributor Author

gzm0 commented May 24, 2023

Added a commit that updates the docs.

@jbedard
Copy link
Member

jbedard commented May 31, 2023

@gzm0 sorry this wasn't merged earlier, would you be able to resolve the conflicts?

We update the jq command to sort them by version (and not release
date). This is important to keep latest on the same major version (and
not flap between 7 / 8).

Triggered by pnpm/pnpm#6424
@gzm0 gzm0 changed the title chore: update pnpm versions, default version: 8.1.0 -> 8.5.1 chore: update old pnpm versions, improve jq script May 31, 2023
@gzm0
Copy link
Contributor Author

gzm0 commented May 31, 2023

Rebased and updated PR title and description (this now doesn't change the default pnpm version anymore).

@jbedard jbedard enabled auto-merge (squash) May 31, 2023 17:41
@jbedard
Copy link
Member

jbedard commented May 31, 2023

Thanks for the quick response! 👍

@jbedard jbedard merged commit ead5b6d into aspect-build:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants