Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR]: Support lockfile v9 and pnpm 9 #1652

Closed
Tracked by #1671
Aghassi opened this issue Apr 16, 2024 · 5 comments
Closed
Tracked by #1671

[FR]: Support lockfile v9 and pnpm 9 #1652

Aghassi opened this issue Apr 16, 2024 · 5 comments
Assignees
@jbedard
Labels
enhancement New feature or request

Comments

@Aghassi
Copy link
Collaborator

Aghassi commented Apr 16, 2024

What is the current behavior?

Error in fail: npm_translate_lock currently supports a maximum lock_version of 6.1, but found 9.0.

Describe the feature

PNPM dropped v9 today and it changes the lockfile version and a few other things. I'm just filing this change as a way to track when rules_js adopts the new lockfile format and supports the new version.

https://github.com/pnpm/pnpm/releases/tag/v9.0.0
@Aghassi Aghassi added the enhancement New feature or request label Apr 16, 2024
@github-actions github-actions bot added the untriaged Requires traige label Apr 16, 2024
@taozhou-glean
Copy link
Contributor

looks like we are beta testing v2.0.0-alpha.0, would be nice if we can add pnpm 9 support in v2

@jbedard jbedard self-assigned this Apr 19, 2024
@jbedard jbedard removed the untriaged Requires traige label Apr 19, 2024
@Lev1ty Lev1ty mentioned this issue May 4, 2024
Merged
@yesudeep
Copy link

yesudeep commented May 4, 2024

It would be great to add support for lockfile version 9.0

@gregmagolan gregmagolan mentioned this issue May 6, 2024
Closed
21 tasks
jbedard added a commit to jbedard/rules_js that referenced this issue May 13, 2024
@jbedard
feat: support pnpm lock v9
9bf7831 
Close aspect-build#1652
jbedard added a commit to jbedard/rules_js that referenced this issue May 14, 2024
@jbedard
feat: support pnpm lock v9
6d4ecf4 
Close aspect-build#1652
jbedard added a commit to jbedard/rules_js that referenced this issue May 14, 2024
@jbedard
feat: support pnpm lock v9
1d33891 
Close aspect-build#1652
jbedard added a commit to jbedard/rules_js that referenced this issue May 14, 2024
@jbedard
feat: support pnpm lock v9
6e0ee58 
Close aspect-build#1652
jbedard added a commit to jbedard/rules_js that referenced this issue May 14, 2024
@jbedard
feat: support pnpm lock v9
8e3e2cb 
Close aspect-build#1652
jbedard added a commit to jbedard/rules_js that referenced this issue May 14, 2024
@jbedard
feat: support pnpm lock v9
bc125a6 
Close aspect-build#1652
jbedard added a commit to jbedard/rules_js that referenced this issue May 14, 2024
@jbedard
feat: support pnpm lock v9
83f5588 
Close aspect-build#1652
jbedard added a commit to jbedard/rules_js that referenced this issue May 14, 2024
@jbedard
feat: support pnpm lock v9
c0b965b 
Close aspect-build#1652
jbedard added a commit to jbedard/rules_js that referenced this issue May 14, 2024
@jbedard
feat: support pnpm lock v9
6401050 
Close aspect-build#1652
jbedard added a commit to jbedard/rules_js that referenced this issue May 14, 2024
@jbedard
feat: support pnpm lock v9
2b06129 
Close aspect-build#1652
jbedard added a commit that referenced this issue May 14, 2024
@jbedard
feat: support pnpm lock v9 (#1679)
3528874 
Close #1652
@jbedard
Copy link
Member

jbedard commented May 14, 2024

Completed for rules_js 2.0: #1679

@jbedard jbedard closed this as completed May 14, 2024
jbedard added a commit to jbedard/rules_js that referenced this issue May 16, 2024
@jbedard
feat: support pnpm lock v9 (aspect-build#1679)
a98e27c 
Close aspect-build#1652
gregmagolan pushed a commit that referenced this issue May 20, 2024
@jbedard @gregmagolan
feat: support pnpm lock v9 (#1679)
c82f68f 
Close #1652
gregmagolan pushed a commit that referenced this issue May 20, 2024
@jbedard @gregmagolan
feat: support pnpm lock v9 (#1679)
89f7c43 
Close #1652
@creatifcoding
Copy link

Hey guys, I would suggest you amend the documentation per the third paragraph to reflect that this issue has been closed.

@jbedard
Copy link
Member

jbedard commented Aug 9, 2024

Thanks for the info @creatifcoding 🙏

See #1882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbedard jbedard

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yesudeep @jbedard @Aghassi @taozhou-glean @creatifcoding