refactor: default npm_package(publishable) to false (#1683)

aspect-build · May 2, 2024 · df06bf6 · df06bf6
1 parent 5d69610
commit df06bf6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/docs/npm_package.md b/docs/npm_package.md
diff --git a/npm/private/npm_package.bzl b/npm/private/npm_package.bzl
@@ -173,7 +173,7 @@ def npm_package(
         include_transitive_types = True,
         include_runfiles = False,
         hardlink = "auto",
-        publishable = True,
+        publishable = False,
         verbose = False,
         **kwargs):
     """A macro that packages sources into a directory (a tree artifact) and provides an `NpmPackageInfo`.

diff --git a/npm/private/test/npm_package_publish/BUILD.bazel b/npm/private/test/npm_package_publish/BUILD.bazel
@@ -7,6 +7,7 @@ npm_package(
         "index.js",
         "package.json",
     ],
+    publishable = True,
 )
 
 npm_package(
@@ -15,6 +16,7 @@ npm_package(
         "index.d.ts",
         "index.js",
     ],
+    publishable = True,
 )
 
 sh_test(