-
-
Notifications
You must be signed in to change notification settings - Fork 108
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
7 changed files
with
141 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
load("@aspect_rules_js//js:defs.bzl", "js_test") | ||
load("@npm//:defs.bzl", "npm_link_all_packages") | ||
|
||
npm_link_all_packages() | ||
|
||
js_test( | ||
name = "runfiles", | ||
data = [ | ||
"test_fixture.md", | ||
"test_fixture.md.generated_file_suffix", | ||
":node_modules/@bazel/runfiles", | ||
], | ||
entry_point = "test.js", | ||
) | ||
|
||
# Path of file must start similar to `test_fixture.md` in order to regression-test a | ||
# scenario where the runfile resolution would accidentally resolve the path to | ||
# `test_fixture.md` through a runfile manifest entry that starts similarly. | ||
genrule( | ||
name = "gen-data", | ||
outs = ["test_fixture.md.generated_file_suffix"], | ||
cmd = """echo "Generated" > $@""", | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "@examples/runfiles", | ||
"private": true, | ||
"dependencies": { | ||
"@bazel/runfiles": "^5.8.1" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
const { join, dirname } = require('path') | ||
const { runfiles } = require('@bazel/runfiles') | ||
|
||
function describe(name, fn) { | ||
console.log(name) | ||
fn() | ||
} | ||
function it(name, fn) { | ||
console.log(` ${name}`) | ||
fn() | ||
} | ||
|
||
function assert(t, msg) { | ||
if (!t) { | ||
throw new Error(msg) | ||
} | ||
} | ||
|
||
describe('runfile resolution', () => { | ||
it('should properly resolve the "test_fixture.md" file', () => { | ||
const testFixturePath = runfiles.resolve( | ||
'aspect_rules_js/examples/runfiles/test_fixture.md' | ||
) | ||
const expectedPath = join(__dirname, 'test_fixture.md') | ||
|
||
assert( | ||
normalizePath(testFixturePath) == normalizePath(expectedPath), | ||
`Expected the test fixture to be resolved next to the spec source file: ${testFixturePath} vs ${expectedPath}` | ||
) | ||
}) | ||
|
||
it('should properly resolve with forward slashes', () => { | ||
const testFixturePath = runfiles.resolve( | ||
'aspect_rules_js\\examples\\runfiles\\test_fixture.md' | ||
) | ||
const expectedPath = join(__dirname, 'test_fixture.md') | ||
|
||
assert( | ||
normalizePath(testFixturePath) == normalizePath(expectedPath), | ||
`Expected the test fixture to be resolved next to the spec source file: ${testFixturePath} vs ${expectedPath}` | ||
) | ||
}) | ||
|
||
it('should properly resolve a subdirectory of a runfile', () => { | ||
const packagePath = runfiles.resolve('aspect_rules_js/examples') | ||
// Alternate with trailing slash | ||
const packagePath2 = runfiles.resolve('aspect_rules_js/examples/') | ||
const expectedPath = dirname( | ||
dirname( | ||
runfiles.resolve( | ||
'aspect_rules_js/examples/runfiles/test_fixture.md.generated_file_suffix' | ||
) | ||
) | ||
) | ||
|
||
assert( | ||
normalizePath(packagePath) == normalizePath(expectedPath), | ||
`Expected to resolve a subdirectory of a runfile: ${packagePath} vs ${expectedPath}` | ||
) | ||
assert( | ||
normalizePath(packagePath2) == normalizePath(expectedPath), | ||
`Expected to resolve a subdirectory of a runfile: ${packagePath2} vs ${expectedPath}` | ||
) | ||
}) | ||
|
||
it('should properly resolve the workspace root of a runfile', () => { | ||
const packagePath = runfiles.resolve('aspect_rules_js') | ||
// Alternate with trailing slash | ||
const packagePath2 = runfiles.resolve('aspect_rules_js/') | ||
const expectedPath = dirname( | ||
dirname( | ||
dirname( | ||
runfiles.resolve( | ||
'aspect_rules_js/examples/runfiles/test_fixture.md.generated_file_suffix' | ||
) | ||
) | ||
) | ||
) | ||
|
||
assert( | ||
normalizePath(packagePath) == normalizePath(expectedPath), | ||
`Expected to resolve the workspace root of a runfile: ${packagePath} vs ${expectedPath}` | ||
) | ||
assert( | ||
normalizePath(packagePath2) == normalizePath(expectedPath), | ||
`Expected to resolve the workspace root of a runfile: ${packagePath2} vs ${expectedPath}` | ||
) | ||
}) | ||
}) | ||
|
||
/** | ||
* Normalizes the delimiters within the specified path. This is useful for test assertions | ||
* where paths might be computed using different path delimiters. | ||
*/ | ||
function normalizePath(value) { | ||
return value.replace(/\\/g, '/') | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
This is a file part of the sources |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.