fix: don't default patch_args when using pnpm.patchedDependencies

aspect-build · Feb 2, 2023 · 8606baf · 8606baf
1 parent ec50e13
commit 8606baf
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/npm/npm_import.bzl b/npm/npm_import.bzl
@@ -430,6 +430,12 @@ WARNING: `package_json` attribute in `npm_translate_lock(name = "{name}")` is de
         if "no-sandbox" not in lifecycle_hooks_execution_requirements["*"]:
             lifecycle_hooks_execution_requirements["*"].append("no-sandbox")
 
+    # TODO (2.0): Stop defaulting patch_args with {"*": ["-p0"]} when no patches are supplied
+    # as this conflicts with the default pnpm.patchedDependencies format of "-p1" and
+    # needs to be explicitly overridden by the user.
+    if len(patches) == 0:
+        patch_args = {}
+
     _npm_translate_lock(
         name = name,
         pnpm_lock = pnpm_lock,