Skip to content

Commit

Permalink
chore: be explicit about node_version in all places we register rules…
Browse files Browse the repository at this point in the history 
…_js_register_toolchains (#1667)
  • Loading branch information
@gregmagolan
gregmagolan committed Apr 21, 2024
1 parent ebf82da commit 431652a
Show file tree
Hide file tree
Showing 25 changed files with 51 additions and 51 deletions.
4 changes: 2 additions & 2 deletions e2e/git_dep_metadata/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_import")

Expand Down
4 changes: 2 additions & 2 deletions e2e/gyp_no_install_script/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_bazel_lib//lib:repositories.bzl", "register_coreutils_toolchains")

Expand Down
4 changes: 2 additions & 2 deletions e2e/js_run_devserver/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/npm_translate_lock/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/npm_translate_lock_auth/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/npm_translate_lock_empty/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/npm_translate_lock_git+ssh/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/npm_translate_lock_multi/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/npm_translate_lock_partial_clone/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/npm_translate_lock_subdir_patch/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/npm_translate_package_lock/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/npm_translate_yarn_lock/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/package_json_module/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/patch_from_repo/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
6 changes: 3 additions & 3 deletions e2e/pnpm_lockfiles/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@rules_nodejs//nodejs:repositories.bzl", "DEFAULT_NODE_VERSION", "nodejs_register_toolchains")
load("@rules_nodejs//nodejs:repositories.bzl", "nodejs_register_toolchains")

nodejs_register_toolchains(
name = "nodejs",
Expand Down
4 changes: 2 additions & 2 deletions e2e/pnpm_repo_install/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/pnpm_workspace/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/pnpm_workspace_deps/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/stamped_package_json/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)
4 changes: 2 additions & 2 deletions e2e/update_pnpm_lock/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/update_pnpm_lock_with_import/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/vendored_tarfile/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/verify_patches/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/webpack_devserver/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down
4 changes: 2 additions & 2 deletions e2e/webpack_devserver_esm/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains()
rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

Expand Down

0 comments on commit 431652a

Please sign in to comment.