Skip to content

Commit

Permalink
refactor: remove legacy update_pnpm_lock default value
Browse files Browse the repository at this point in the history
  • Loading branch information
jbedard committed Apr 8, 2024
1 parent 0703a2c commit 38f5449
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions npm/private/npm_translate_lock.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def npm_translate_lock(
pnpm_lock = None,
npm_package_lock = None,
yarn_lock = None,
update_pnpm_lock = None,
update_pnpm_lock = False,
node_toolchain_prefix = "nodejs",
yq_toolchain_prefix = "yq",
preupdate = [],
Expand Down Expand Up @@ -617,11 +617,6 @@ def npm_translate_lock(
for value_key, value_value in value.items():
bins_string_list_dict[key].append("{}={}".format(value_key, value_value))

# Default update_pnpm_lock to True if npm_package_lock or yarn_lock is set to
# preserve pre-update_pnpm_lock `pnpm import` behavior.
if update_pnpm_lock == None and (npm_package_lock or yarn_lock):
update_pnpm_lock = True

if not update_pnpm_lock and preupdate:
fail("expected update_pnpm_lock to be True when preupdate are specified")

Expand Down

0 comments on commit 38f5449

Please sign in to comment.