don't rewrite list comp to generator expression in short-circuiting f…

[graingert]

…unctions

consider the side-effecting function _upgrade

if not all([_upgrade(x) for x in items]):
    raise ValidationError("one or more items failed to upgrade")

the functions all and any don't always consume their input fully and so will skip the side-effect for those items

[MarcoGorelli]

nice, thanks for catching this, I hadn't considered that!

[asottile]