Fix the build on Rust 1.73.0 and nearby versions #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust 1.71 and earlier ignored build script outputs like "cargo::name=value". Rust nightly from around 5-May-2024 complains about unexpected_cfgs , and the suggested solution is to add a "cargo::name=value" output to the build script. But intermediate Rust versions including 1.73.0 treat that syntax as an error. Happily, all tested Rust versions accept and understand "cargo:name=value" (note the single colon). This fixes a regression introduced by #574 and not yet released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.71 and earlier ignored build script outputs like "cargo::name=value". Rust nightly from around 5-May-2024 complains about unexpected_cfgs , and the suggested solution is to add a "cargo::name=value" output to the build script. But intermediate Rust versions including 1.73.0 treat that syntax as an error. Happily, all tested Rust versions accept and understand "cargo:name=value" (note the single colon).
This fixes a regression introduced by #574 and not yet released.