Merge pull request #49 from asomers/clippy

Run Clippy in CI

.cirrus.yml

@@ -28,6 +28,10 @@ test_task:
     - if rustc --version | grep -q nightly; then
     -   cargo doc --all-features --no-deps
     - fi
+  clippy_script:
+    - if rustc --version | grep -q nightly; then
+    -   cargo clippy --all-features --all-targets
+    - fi
   before_cache_script: rm -rf $CARGO_HOME/registry/index
 
 codecov_task:

src/mutex.rs

@@ -175,6 +175,9 @@ impl<T: ?Sized> Clone for MutexWeak<T> {
     }
 }
 
+// Clippy doesn't like the Arc within Inner.  But the access rules of the Mutex
+// make it safe to send.  std::sync::Mutex has the same Send impl
+#[allow(clippy::non_send_fields_in_send_ty)]
 unsafe impl<T: ?Sized + Send> Send for MutexWeak<T> {}
 unsafe impl<T: ?Sized + Send> Sync for MutexWeak<T> {}
 
@@ -424,6 +427,9 @@ impl<T: 'static + ?Sized> Mutex<T> {
     }
 }
 
+// Clippy doesn't like the Arc within Inner.  But the access rules of the Mutex
+// make it safe to send.  std::sync::Mutex has the same Send impl
+#[allow(clippy::non_send_fields_in_send_ty)]
 unsafe impl<T: ?Sized + Send> Send for Mutex<T> {}
 unsafe impl<T: ?Sized + Send> Sync for Mutex<T> {}
 

src/rwlock.rs

@@ -653,6 +653,9 @@ impl<T: 'static + ?Sized> RwLock<T> {
     }
 }
 
+// Clippy doesn't like the Arc within Inner.  But the access rules of the RwLock
+// make it safe to send.  std::sync::RwLock has the same Send impl
+#[allow(clippy::non_send_fields_in_send_ty)]
 unsafe impl<T: ?Sized + Send> Send for RwLock<T> {}
 unsafe impl<T: ?Sized + Send + Sync> Sync for RwLock<T> {}