Get server working, swap yarn for pnpm #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathaniel-furniss-glean
requested review from
naveen-ls-glean and
taozhou-glean
taozhou-glean
approved these changes
Aug 4, 2025
Contributor
There was a problem hiding this comment.
Thanks! can we update .codesandbox/tasks.json as well, we have https://codesandbox.io/p/github/askscio/glean-browser-api/main running from master - I pinged Tony to add you as editor to the org there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I was doing something wrong, but cloning this repo and running the expected commands results in a bunch of errors.
Took some time to fix the errors, and also swapped from yarn to pnpm, as any recently joined devs don't have yarn installed but will have pnpm.
Removed loadash as it's deprecated, and added express, otherwise the server wouldn't start