Fix #266 bitstamp trader fails to buy

[Siim]

Fix #266

ticker.ask had type of string and as a result the amount calculation failed. The price should be parsed as float.

amount = this.getBalance(this.currency) / (parseFloat(this.ticker.ask) + (parseFloat(this.ticker.ask)*this.fee));

Fix #240

Fixed floating point to 4 decimal places, because more than 4 places caused inaccurate calculations.

Btw shouldn't we make all the calculations using cents and satoshis and store all the monetary and asset values in an integer type?

[jonny64]

/var/projects/gekko/core/portfolioManager.js:138
eFloat(this.ticker.ask) + (parseFloat(this.ticker.ask)*this.fee))).toFixed(4);
SyntaxError: Unexpected token ;

you have unbalanced parenthesis

could you please also undo whitespace change, so this can be cleanly merged?

[Siim]

Fixed the issues.

[jonny64]

looks okay, thanks!

it looks like you have commited someone's key and secret in mocha_test/portfolioManager.js
is this okay? will this test pass every time in future?

this pull request contains merge conflicts that must be resolved

hm)
you can create separate branch
git fetch && git branch fix_bitstamp 21de73c
and recommit needed changes (you can use git checkout --patch to undo whitespace change)
and issue separate pull requests for whitespace and the rest

[Siim]

Yes it is ok with the key and the test should pass. The key and secret is just for the sake to fill in the config fields to make the test work, otherwise the test will fail.

I'll look into the merge conflict.

[askmike]

I am assuming this error was specific to Bitstamp's v1 API. As we switched to the v2 API (for buy/sell orders) I think this should not be an issue anymore!

[askmike]

actually, I didn't see the tests before. Keeping this open for a little bit..