Skip to content
This repository has been archived by the owner on Feb 16, 2020. It is now read-only.

Improve Binance getTicker log entry #1954

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Conversation

difelice
Copy link
Contributor

Resolves #1953

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Log improvements

  • What is the current behavior? (You can also link to an open issue here)

  1. Binance log code consistency.
  2. Binance getTicker call logs the full response from API causing too much noise in log files.
  • What is the new behavior (if this is a feature change)?
    The getTicker call logs how many symbols were loaded.

  • Other information:

@askmike
Copy link
Owner

askmike commented Feb 21, 2018

great stuff!

I actually want to remove all binance output logs at some point, they were added to deal with the many problems people were encountering with the binance API (a while ago).

@askmike askmike merged commit 669f4e2 into askmike:develop Feb 21, 2018
@difelice
Copy link
Contributor Author

Sure let me know if you need a hand. Thanks.

This was referenced Mar 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binance getTicker log entry too noisy
2 participants