Chunked responses and env support #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows us to pass the ssh user and a proxy 'name' (mapping to the authenticating user) that will allow sshcommand to identify who is performing commands.
This sets the stage for letting other projects benefit from something Dokku-specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows pushes to receive chunked responses, which are useful when running git-http-backend behind a proxy.
As well, it supports setting a default ENV for the
gitcommand, and specifying authentication information. This is useful when the git repository in question triggers a git pre-receive hook that checks the push environment to see if the user can actually push to the repository in question. For an example of that, seedokku, which has support via thedokku-aclplugin to limit pushes based on the authenticating user.