small bug fixed #14
Merged
small bug fixed #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I think I have found a small bug and fixed it!
When client requests with header setting as "Git-Protocol: version=2", the origin code failed. The client shows error with "expected flush after ref listing". By using wireshark, I realized the server failed to handle the second request correctly.
And finally I found that the cmd.Env is not set correctly when the "Git-Protocol" header is set since it's always going to be covered the second assignment. Simply changing the order of assignment works.
It's my first time to create a pull request and try to make some contribution to your project. It will be kind of you to let me know if I did anything wrong.