Skip to content

Improve: Delegate sz_find/sz_rfind single-byte search to libc memchr/memrchr #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
belugabehr wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

Improve: Delegate sz_find/sz_rfind single-byte search to libc memchr/memrchr #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions include/stringzilla/find.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@

#include "types.h"

#if !SZ_AVOID_LIBC
#include <string.h> // `memchr`, `memrchr`
#endif

#include "compare.h" // `sz_equal`

#ifdef __cplusplus
Expand Down Expand Up @@ -2042,6 +2046,10 @@ SZ_DYNAMIC sz_cptr_t sz_rfind_byte(sz_cptr_t haystack, sz_size_t h_length, sz_cp
}

SZ_DYNAMIC sz_cptr_t sz_find(sz_cptr_t haystack, sz_size_t h_length, sz_cptr_t needle, sz_size_t n_length) {
if (h_length < n_length || !n_length) return SZ_NULL_CHAR;
#if !SZ_AVOID_LIBC
if (n_length == 1) return (sz_cptr_t)memchr(haystack, *(sz_u8_t const *)needle, h_length);
#endif
#if SZ_USE_SKYLAKE
return sz_find_skylake(haystack, h_length, needle, n_length);
#elif SZ_USE_HASWELL
Expand All @@ -2058,6 +2066,10 @@ SZ_DYNAMIC sz_cptr_t sz_find(sz_cptr_t haystack, sz_size_t h_length, sz_cptr_t n
}

SZ_DYNAMIC sz_cptr_t sz_rfind(sz_cptr_t haystack, sz_size_t h_length, sz_cptr_t needle, sz_size_t n_length) {
if (h_length < n_length || !n_length) return SZ_NULL_CHAR;
#if !SZ_AVOID_LIBC && defined(__GLIBC__)
if (n_length == 1) return (sz_cptr_t)memrchr(haystack, *(sz_u8_t const *)needle, h_length);
#endif
#if SZ_USE_SKYLAKE
return sz_rfind_skylake(haystack, h_length, needle, n_length);
#elif SZ_USE_HASWELL
Expand Down