Skip to content

Conversation

ashphy
Copy link
Owner

@ashphy ashphy commented Jun 22, 2025

Summary

  • Upgrade @biomejs/biome from v1.9.4 to v2.0.0
  • Migrate configuration using automated migration tool
  • Apply lint fixes for new v2 rules and style guidelines

Changes Made

  • Package update: Updated @biomejs/biome to 2.0.0 in package.json
  • Configuration migration: Used biome migrate --write for automatic config updates
  • Config structure changes:
    • Updated schema to v2.0.0
    • Converted ignore patterns to includes with negation (\!**/)
    • Moved organizeImports to assist.actions.source.organizeImports
    • Added new default style rules from v2
  • Code fixes: Applied automatic fixes for:
    • Import organization and sorting
    • Unused imports and variables removal
    • Object.hasOwn() usage instead of Object.prototype.hasOwnProperty
    • Function parameter prefixing for unused params

Test Plan

  • Install updated dependency
  • Run migration tool successfully
  • Apply all lint fixes
  • Verify npm run lint passes without errors
  • Ensure all TypeScript compilation works
  • Confirm existing functionality unchanged

🤖 Generated with Claude Code

ashphy and others added 2 commits June 22, 2025 21:13
- Update @biomejs/biome from 1.9.4 to 2.0.0
- Migrate configuration using biome migrate --write
- Convert ignore patterns to includes with negation
- Move organizeImports to assist.actions.source
- Apply automatic lint fixes for new v2 rules
- Replace Object.prototype.hasOwnProperty with Object.hasOwn
- Fix unused imports and variables
- Update import organization according to new style rules

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Upgrade @biomejs/biome from 2.0.0 to 2.0.4 (latest)
- Update schema URL to match CLI version 2.0.4
- Verify lint configuration works correctly

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@ashphy ashphy requested a review from Copilot June 22, 2025 12:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Biome linter/formatter from v1.x to v2.x, migrates its configuration using the official migration tool, and applies automated lint fixes required by the new rules.

  • Bumped @biomejs/biome dependency to v2.0.4
  • Migrated biome.json schema and restructured ignoreincludes, moved organizeImports under assist.actions
  • Applied automatic import sorting, removal of unused vars/imports, and updated code patterns (e.g., Object.hasOwn)

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/RFC9535/jsonpath-compliance-test-suite.test.ts Reordered imports to satisfy new lint rules
src/utils/enumerateNode.ts Removed unused path destructuring
src/parsers/root.ts Prefixed unused selector param; replaced hasOwnProperty calls with Object.hasOwn
src/parsers/filter_selector.ts Removed unused toArray import
src/parsers/array_slice_selector.ts Reordered imports
src/parser.ts Reordered imports
src/functions/value.ts Reordered imports
src/functions/search.ts Reordered imports
src/functions/match.ts Reordered imports
src/functions/length.ts Reordered imports
src/functions/function_definitions.ts Reordered imports
src/functions/count.ts Reordered imports
src/comparator/NodeComparator.ts Removed unused Node import
package.json Updated @biomejs/biome from 1.9.4 to 2.0.4
biome.json Updated schema URL to 2.0.4, converted ignore to includes, adjusted formatter/linter settings
Comments suppressed due to low confidence (1)

package.json:41

  • The PR description mentions upgrading to v2.0.0 but package.json uses v2.0.4; please align the PR summary or package version to avoid confusion.
		"@biomejs/biome": "2.0.4",

@ashphy ashphy merged commit 04cbbba into main Jun 22, 2025
10 checks passed
@ashphy ashphy deleted the upgrade/biome-v2 branch June 22, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant