Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump F# compiller to 8 version #1326

Closed
rstm-sf opened this issue Feb 17, 2024 · 4 comments
Closed

Bump F# compiller to 8 version #1326

rstm-sf opened this issue Feb 17, 2024 · 4 comments
Milestone
97

Comments

@rstm-sf
Copy link

rstm-sf commented Feb 17, 2024 •
edited
Loading

Currently the F# code compiled with version 6 of the compiler, we need bump to version 8

Similar #1229
@rstm-sf
Copy link
Author

rstm-sf commented Jun 1, 2024

Done: f4a0269

@rstm-sf rstm-sf closed this as completed Jun 1, 2024
@ashmind ashmind reopened this Jun 1, 2024
@ashmind
Copy link
Owner

ashmind commented Jun 1, 2024

@rstm-sf This will take a bit more time unfortunately, original commit did not update properly.

@psfinaki FYI -- I am seeing some challenges with the Run mode. I think SharpLab was never able to compile target:exe (some complexity with code not finding a win32manifest file), but previously I could pass the AST directly to the compiler, then rewrite the resulting IL to approximate an exe entry point. However the API has changed and I can no longer do this, so it seems I have to actually support exe properly.

This might take a bit of time to figure out.

ashmind added a commit to ashmind/mirrorsharp that referenced this issue Jun 1, 2024
@ashmind
[ashmind/SharpLab#1326] Add CompileAsync() to FSharpSession and fix s…
5afa191 
…ome historical issues
ashmind added a commit that referenced this issue Jun 1, 2024
@ashmind
[gh-1326] Update SharpLab to new F# compilation; unrelated formatting…
9baa8c3 
… fixes
@ashmind
Copy link
Owner

ashmind commented Jun 2, 2024

All done now. 👍

@ashmind ashmind closed this as completed Jun 2, 2024
@ashmind ashmind added this to the 97 milestone Jun 2, 2024
@psfinaki
Copy link

psfinaki commented Jun 3, 2024

Thanks a lot @ashmind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
97
Development

No branches or pull requests
3 participants
@ashmind @rstm-sf @psfinaki