Skip to content

Conversation

@Sparktan24
Copy link
Collaborator

Make sure that the function for the comments counter is covered with unit tests using Jest.

Make sure that you have tests for all edge cases.

@Sparktan24 Sparktan24 linked an issue Feb 12, 2023 that may be closed by this pull request
@ashmalzahra
Copy link
Owner

Hi @Sparktan24 ,

Your project is complete! ⚡🔥 There is nothing else to say other than... it's time to merge it
Congratulations! 🎉

Highlights 🎉🔥

  • All checks passed ✔

Optional suggestions ☂

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

@Sparktan24 Sparktan24 merged commit 1f26615 into develop Feb 12, 2023
@Sparktan24 Sparktan24 deleted the comments-counter-test branch February 12, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[3pt] - Add tests for comments counter - Student B

3 participants