Skip to content

Conversation

@ashmalzahra
Copy link
Owner

  • When the page loads, the webapp retrieves data from:
    • The selected API and shows the list of items on screen

@Sparktan24
Copy link
Collaborator

Hi @ashmalzahra

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  1. No Linters errors 💯
  2. All requirements are complete 💯

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ashmalzahra ashmalzahra merged commit e87edf9 into develop Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[3pt] - Add all items counter on the Homepage - Student A [3pt] - Add tests for items counter - Student A

2 participants