Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDP-related improvements to data module and logging #594

Merged
merged 5 commits into from
Sep 18, 2023
Merged

DDP-related improvements to data module and logging #594

merged 5 commits into from
Sep 18, 2023

Commits on Aug 17, 2023

  1. Dividing batch size by number of devices in MNISTDataModule's setup fn.

    @tesfaldet
    tesfaldet committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    f50b9f2 View commit details
    Browse the repository at this point in the history

  2. log file is now the same across devices when training in a DDP setting.

    @tesfaldet
    tesfaldet committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    68446ce View commit details
    Browse the repository at this point in the history

  3. Rank-aware pylogger.

    @tesfaldet
    tesfaldet committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    3f2ad96 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Recreated the rank-aware logger so that it's making use of LoggerAdap… 

    …ter, avoiding weird hijacking of logging functions.
    @tesfaldet
    tesfaldet committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    abd0848 View commit details
    Browse the repository at this point in the history

  2. Adding 'extra' kwarg to RankedLogger.

    @tesfaldet
    tesfaldet committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    462909d View commit details
    Browse the repository at this point in the history