Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer Implemented #61

Merged
merged 2 commits into from
Jan 1, 2022
Merged

Footer Implemented #61

merged 2 commits into from
Jan 1, 2022

Conversation

sn2606
Copy link
Contributor

@sn2606 sn2606 commented Dec 31, 2021

Related Issue or bug

  • Footer is not visible/Implemented

Fixes: #55

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Inspect element on web browsers
  • Three web browsers tested: Safari, Chrome, Firefox

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original

Updated
image

Updated (Responsive)
image

@welcome
Copy link

welcome bot commented Dec 31, 2021

Hello there!👋 Welcome to the project!💖⚡

Thank you and congrats🎉 for opening your very first issue in this project. We at hackStation provide a platform to share your work in number. Please adhere to our Code of Conduct.🙌 Kindly ensure you have fulfilled all the project guidelines.

Copy link
Collaborator

@aakankshabhende aakankshabhende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @sn2606

@aakankshabhende aakankshabhende merged commit de38664 into ashishnagpal2498:master Jan 1, 2022
@welcome
Copy link

welcome bot commented Jan 1, 2022

Congrats on merging your first pull request! 🎉 All the best for your amazing open source journey ahead 🚀

@ashishnagpal2498 ashishnagpal2498 added Level-1 SWOC issue - Easy issue SWOC Script Winter of Code UI/UX labels Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level-1 SWOC issue - Easy issue SWOC Script Winter of Code UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a footer
3 participants