Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#56 Responsive header #57

Merged
merged 2 commits into from
Dec 19, 2021

Conversation

Reckon77
Copy link
Contributor

@Reckon77 Reckon77 commented Dec 13, 2021

Related Issuse or bug

  • Info about Issue or bug

Fixes: #56

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Tested using chrome developer tools to check the responsiveness of the navbar

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
**![Screenshot 2021
Screenshot 2021-12-13 190113
-12-13 184805](https://user-images.githubusercontent.com/56126160/145821107-61890f90-8ca4-4c0e-b046-e8bc98706e10.jpg)** updated scree
Screenshot 2021-12-13 184742
nshot

@welcome
Copy link

welcome bot commented Dec 13, 2021

Hello there!👋 Welcome to the project!💖⚡

Thank you and congrats🎉 for opening your very first issue in this project. We at hackStation provide a platform to share your work in number. Please adhere to our Code of Conduct.🙌 Kindly ensure you have fulfilled all the project guidelines.

<NavLink exact to="/">
<img src="/logo.png" alt="logo-here" />
<img src="/logo.png" alt="logo-here"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo should be in the left and reduce the size of dropdown menu icon

@ashishnagpal2498 ashishnagpal2498 merged commit ca073f2 into ashishnagpal2498:master Dec 19, 2021
@welcome
Copy link

welcome bot commented Dec 19, 2021

Congrats on merging your first pull request! 🎉 All the best for your amazing open source journey ahead 🚀

@Reckon77 Reckon77 deleted the responsive-navbar branch December 19, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsive Header
2 participants