Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added contributor's table #49

Merged
merged 2 commits into from
Feb 24, 2021
Merged

Added contributor's table #49

merged 2 commits into from
Feb 24, 2021

Conversation

himanshu007-creator
Copy link
Contributor

@himanshu007-creator himanshu007-creator commented Feb 23, 2021

Related Issuse or bug

Fixes: #47

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

2021-02-23 (2)

@welcome
Copy link

welcome bot commented Feb 23, 2021

Hello there!👋 Welcome to the project!💖⚡

Thank you and congrats🎉 for opening your very first issue in this project. We at hackStation provide a platform to share your work in number. Please adhere to our Code of Conduct.🙌 Kindly ensure you have fulfilled all the project guidelines.

@himanshu007-creator
Copy link
Contributor Author

I am a participant in both DWOC and SWOC. So please add these both tags along with Level tags accordingly

@ashishnagpal2498
Copy link
Owner

What if a new person comes in and contribute to the project ? Check for github plugin. There are many for such thing. Reference - https://github.com/smaranjitghose/doc2pen#our-valuable-contributors-

@himanshu007-creator
Copy link
Contributor Author

himanshu007-creator commented Feb 23, 2021

What if a new person comes in and contribute to the project ? Check for github plugin. There are many for such thing. Reference - https://github.com/smaranjitghose/doc2pen#our-valuable-contributors-

We just need to copy the table item and modify it. It's simple. And the one available here is quite simple. If you want it to be there, that can also be done.

@ashishnagpal2498
Copy link
Owner

Since there was no such major change to readme. Reducing level to DWOC - level1

@ashishnagpal2498 ashishnagpal2498 added documentation Improvements or additions to documentation DWOC DevScript Winter of Code Level-1 SWOC issue - Easy issue labels Feb 24, 2021
@ashishnagpal2498 ashishnagpal2498 merged commit 6ed83b3 into ashishnagpal2498:master Feb 24, 2021
@welcome
Copy link

welcome bot commented Feb 24, 2021

Congrats on merging your first pull request! 🎉 All the best for your amazing open source journey ahead 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation DWOC DevScript Winter of Code Level-1 SWOC issue - Easy issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a contributors table in readme
2 participants