Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Charts #44

Merged
merged 3 commits into from
Feb 14, 2021
Merged

Conversation

sanjay270899
Copy link
Contributor

Fixes: #40

Made LineChart and PieChart component.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original
image
Updated
charts_40

@ashishnagpal2498
Copy link
Owner

Can you make it 50% each in a single component. The issue clearly state that divide component horizontally into two halves.

@sanjay270899
Copy link
Contributor Author

@ashishnagpal2498
image

@ashishnagpal2498
Copy link
Owner

Can you make both of these chart component to 70% and Add some text in 30% div.
Heading should not be inside chart but shown separately. (not a simple header tag)

@sanjay270899
Copy link
Contributor Author

@ashishnagpal2498
70% means 70vh?
Total height 200vh for both charts?

@ashishnagpal2498
Copy link
Owner

@ashishnagpal2498
70% means 70vh?
Total height 200vh for both charts?

I am talking about width buddy. Dividing the component horizontally. 70% - chart, 30% - description 7:3 ratio.

@sanjay270899
Copy link
Contributor Author

@ashishnagpal2498 Like this?
image

@ashishnagpal2498
Copy link
Owner

Yes @sanjay270899

@sanjay270899
Copy link
Contributor Author

@ashishnagpal2498 Done.
image

@ashishnagpal2498 ashishnagpal2498 added Hard SWOC Script Winter of Code UI/UX labels Feb 14, 2021
@ashishnagpal2498 ashishnagpal2498 merged commit 56f2f2b into ashishnagpal2498:master Feb 14, 2021
@sanjay270899
Copy link
Contributor Author

@ashishnagpal2498 It was for DWOC. I think by mistake you have added labels for SWOC.

@ashishnagpal2498 ashishnagpal2498 added DWOC DevScript Winter of Code Level-5 DWOC issue - Major Contribution, Adding multiple features etc and removed Hard SWOC Script Winter of Code labels Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DWOC DevScript Winter of Code Level-5 DWOC issue - Major Contribution, Adding multiple features etc UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amcharts Homepage component
2 participants