Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upcoming Contest Card Component #36

Merged
merged 2 commits into from
Feb 6, 2021
Merged

Upcoming Contest Card Component #36

merged 2 commits into from
Feb 6, 2021

Conversation

sanjay270899
Copy link
Contributor

Closes #35

Made Upcoming Card Component.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original
image

Updated
image

@welcome
Copy link

welcome bot commented Feb 5, 2021

Hello there!👋 Welcome to the project!💖⚡

Thank you and congrats🎉 for opening your very first issue in this project. We at hackStation provide a platform to share your work in number. Please adhere to our Code of Conduct.🙌 Kindly ensure you have fulfilled all the project guidelines.

ashishnagpal2498
ashishnagpal2498 requested changes Feb 5, 2021
View reviewed changes
frontend/src/App.js Outdated

function App() {
return (
<Router>
<div className="App">
<Navbar/>
<Card
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding card here, create another component which has state of all cards( using Hooks) . Use that and run a map on Card ( atleast 3 items). Display that component here. ( Name it "Cards")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, make sure its responsive. Commit the changes as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashishnagpal2498 Done. Pushed the latest code.

frontend/src/components/styles/Card.css
}

.read_more {
margin: 1rem auto 0 auto;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color codes doesn't look good. Either make it bit impressive or use the design provided.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashishnagpal2498 Now it is fine?
image

@ashishnagpal2498 ashishnagpal2498 added DWOC DevScript Winter of Code Level-4 DWOC issue - Implementing new features UI/UX labels Feb 6, 2021
@ashishnagpal2498 ashishnagpal2498 merged commit dc2addd into ashishnagpal2498:master Feb 6, 2021
@welcome
Copy link

welcome bot commented Feb 6, 2021

Congrats on merging your first pull request! 🎉 All the best for your amazing open source journey ahead 🚀

@sanjay270899
Copy link
Contributor Author

@ashishnagpal2498 Can you also add Labels for SWOC?

@ashishnagpal2498
Copy link
Owner

The issue was specifically for DWOC.

@ashishnagpal2498 ashishnagpal2498 added Medium SWOC Script Winter of Code and removed DWOC DevScript Winter of Code Level-4 DWOC issue - Implementing new features labels Feb 9, 2021
@sanjay270899
Copy link
Contributor Author

@ashishnagpal2498 I noticed today that you have removed DWOC labels and added SWOC. Please changed it again.

@sanjay270899
Copy link
Contributor Author

@ashishnagpal2498 I have told to add SWOC labels also if possible... But you have removed DWOC labels. For me, DWOC is at higher priority. So please change the labels to DWOC. Sorry for the inconvenience.

@ashishnagpal2498
Copy link
Owner

I cannot add two labels to a single PR.

@ashishnagpal2498 ashishnagpal2498 added DWOC DevScript Winter of Code Level-4 DWOC issue - Implementing new features and removed Medium SWOC Script Winter of Code labels Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashishnagpal2498 ashishnagpal2498 ashishnagpal2498 requested changes

Assignees
No one assigned
Labels
DWOC DevScript Winter of Code Level-4 DWOC issue - Implementing new features UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upcoming Contest Card Component
2 participants
@sanjay270899 @ashishnagpal2498