Tn/add project vars #934
Tn/add project vars #934
Conversation
TylerNoblett
requested review from
jkennedyvz,
jrozner and
JoelAtDeluxe
as code owners
| var newGlobalVar = newGlobalVarGen(1) | ||
| var VarExpelliarmus = newGlobalVar("Expelliarmus", "disarm an opponent") | ||
| var VarAlohomora = newGlobalVar("Alohomora", "unlock doors") | ||
| var VarAscendio = newGlobalVar("Ascendio", "lifts the caster high into the air") | ||
| var VarImperio = newGlobalVar("Imperio", "control another person") | ||
| var VarLumos = newGlobalVar("Lumos", "creates a narrow beam of light") | ||
| var VarObliviate = newGlobalVar("Obliviate", "erases memories") |
There was a problem hiding this comment.
haha I'm all about 1) honoring convention and 2) referencing media franchises from my childhood in my work
|
whoops sorry Joel; I've updated a few things since you last looked - I second guessed some decisions as I was copying a bunch of this stuff over to create operation variables |
| CREATE TABLE global_vars ( | ||
| id INT AUTO_INCREMENT, | ||
| name VARCHAR(255) NOT NULL UNIQUE, | ||
| value VARCHAR(255) NOT NULL, |
There was a problem hiding this comment.
Is VARCHAR(255) large enough? What if* I wanted to pass an RSA key or longer document?
Maybe this isn't a huge deal for the first pass since we can grow the field later?
There was a problem hiding this comment.
oh that's a good point - yeah I can def change that
There was a problem hiding this comment.
changed the type to TEXT - how does that sound?
There was a problem hiding this comment.
just tested by adding a really long doc and the UI 'breaks' so I'll fix that as well
This PR adds project specific vars that can be accessed by a super admin. This is one of three PRs to address this request; the next will add project specific variables and the final one will send both sets of variables to service workers
Notes
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.