Tn/add discoverable creds #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerNoblett
requested review from
jkennedyvz,
jrozner and
JoelAtDeluxe
as code owners
|
If I fudge around and get a longer error message from the backend it explodes the login window size. 
I can't hit enter here to go to the discovery flow. 
|
|
I'll take a look! @jkennedyvz |
|
@jkennedyvz I fixed the error UI;
EDIT: Oh I think I understand. Do you mean that you could enter a username for username/password or username for the former webauthn setup and then click enter without tabbing? - I'll see what I can do |
|
@jkennedyvz now you can click "Enter" to start the login flow |
jkennedyvz
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds discoverable login functionality
Screen.Recording.2023-09-20.at.11.23.52.AM.mov
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.