-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tn/swap mux for chi #843
Merged
Merged
Tn/swap mux for chi #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerNoblett
requested review from
jkennedyvz,
jrozner and
JoelAtDeluxe
as code owners
May 26, 2023 14:37
TylerNoblett
commented
May 26, 2023
TylerNoblett
commented
May 26, 2023
TylerNoblett
commented
May 26, 2023
JoelAtDeluxe
reviewed
Jun 3, 2023
JoelAtDeluxe
reviewed
Jun 3, 2023
JoelAtDeluxe
reviewed
Jun 3, 2023
JoelAtDeluxe
reviewed
Jun 3, 2023
JoelAtDeluxe
reviewed
Jun 3, 2023
Co-authored-by: Joel Smith <joel.smith@originate.com>
@JoelAtDeluxe I think I've addressed all of your feedback - thanks again for taking a look! |
jkennedyvz
reviewed
Jun 14, 2023
jkennedyvz
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing a bunch of research, it seemed that Chi was the best alternative to gorilla/mux, so I've swapped them out in this PR.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.