Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add button to update key/credential name #834

Merged
merged 5 commits into from
Jun 14, 2023

Conversation

TylerNoblett
Copy link
Collaborator

This PR addresses the request in 824 to add a feature to update the key/credential name

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@TylerNoblett TylerNoblett changed the title update key/credential name add button to update key/credential name May 12, 2023
Copy link
Collaborator

@JoelAtDeluxe JoelAtDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Base automatically changed from tn/webauthn-revisions to main May 16, 2023 21:46
@jrozner
Copy link
Member

jrozner commented May 16, 2023

@TylerNoblett this needs to get rebased on or have main merged in due to the changes for renaming key to credential.

@TylerNoblett
Copy link
Collaborator Author

@jrozner should be good to merge now!

@jkennedyvz jkennedyvz merged commit 448c5ad into main Jun 14, 2023
@TylerNoblett TylerNoblett deleted the tn/webauthn-revisions-change-credential-name branch October 18, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants