Tn/use new authn lib #801
Merged
Tn/use new authn lib #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerNoblett
requested review from
jkennedyvz,
jrozner and
JoelAtDeluxe
as code owners
TylerNoblett
commented
Mar 30, 2023
| @@ -22,6 +22,25 @@ export const toKeycode = (c: string) => c.charCodeAt(0) | |||
|
|
|||
| export const toByteArray = (s: string) => Uint8Array.from(atob(s), toKeycode) | |||
|
|
|||
| const base64UrlToBase64 = (input: string) => { | |||
There was a problem hiding this comment.
the only substantial change is the the 'challenge' string is now being sent in base64url (which is just base 64 but url safe; – is used instead of + and _ is used instead of /) and there are some padding differences
jkennedyvz
approved these changes
Apr 1, 2023
jrozner
added a commit
that referenced
this pull request
May 6, 2023
* use new library * upgrade to match new library spec
jrozner
added a commit
that referenced
this pull request
May 6, 2023
* use new library * upgrade to match new library spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authn library has been archived, so I changed a few things to use the recommended fork
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.