Support Ruby 3.1 UCRT binary #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubyInstaller has migrate from msvcrt.dll to ucrt.dll: https://rubyinstaller.org/2021/12/31/rubyinstaller-3.1.0-1-released.html So that symbols should be loaded from later one. Althouth I considered introducing a new constant like `UCRT_DLL`, this commit still using `MSVCRT_DLL` even if Ruby is run on ucrt.dll to keep backward compatibility. I think replacing `MSVCRT_DLL` with `UCRT_DLL` is almost meaningless, they won't used at same time. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
ashie
force-pushed
the
support-ruby-3.1-ucrt-wip
branch
13 times, most recently
from
851ad99 to
1477962
Compare
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
ashie
force-pushed
the
support-ruby-3.1-ucrt-wip
branch
from
1477962 to
da4f415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RubyInstaller has migrate from msvcrt.dll to ucrt.dll:
https://rubyinstaller.org/2021/12/31/rubyinstaller-3.1.0-1-released.html
So that symbols should be loaded from later one.
Althouth I considered introducing a new constant like
UCRT_DLL, thiscommit still using
MSVCRT_DLLeven if Ruby is run on ucrt.dll to keepbackward compatibility. I think replacing
MSVCRT_DLLwithUCRT_DLLis almost meaningless, they won't used at same time.
Signed-off-by: Takuro Ashie ashie@clear-code.com