Ray tracing support #186
Ray tracing support #186
Conversation
Update from master
…le in rt extension
…d names for VK_KHR_get_memory_requirements2 and VK_KHR_get_physical_device_properties2 (both are commonly used, and required for ray tracing)
…rties info (such as shader group handle size)
…ension names from EXT to proper place.
I wanted to generate all the extension names from the vk.xml file anyway, I just haven't had the time to implement it.
Sounds good to me. Ideally we would have one big place with all the examples, they don't necessarily need to share code. My only concern is that I can't really maintain this example because I don't have a turing card. I'll try to give you a proper review later today or tomorrow. Thanks! |
|
Will update my stuff now that #188 is in! Cheers |
|
@MaikKlein would it be possible to do a (hopefully quick) update to Vulkan 1.1.97.0? There was a lot of Turing churn and and I'm debugging a weird crash that could be from a broken FFI in the past. (1.1.97.0 is really stable now) |
|
@gwihlidal #189 I'll review it tomorrow. |
|
@gwihlidal #189 is now merged. |
Updated from master
|
Works! The remaining issues were in my app, not this PR, so it's ready for merging.
This PR now gives full access to NV RT from rust :) |
|
bors r+ |
186: Ray tracing support r=MaikKlein a=gwihlidal This PR adds support for VK_NV_ray_tracing! (and initial support for VK_EXT_descriptor_indexing, but more support coming for that). One piece I'm unsure if you have a more suggested approach is what I added to ext/mod.rs for names (both of those extensions are very commonly used, and also required for ray tracing). Maybe there should be a names.rs or something which can implement a static string function for all names that don't warrant their own extension struct? I have a local example I've been working on that has been testing against this code, as well as support for descriptor indexing. Originally, I was adding an nv_ray_tracing.rs example alongside triangle and texture, but ray tracing requires some specific extensions and also it doesn't need frame bindings, render states, etc. Additionally, this example only works on NV and with a Turing-class GPU, so I'm unsure if it should co-exist with the basic examples? Because of this, I'm going to first start with a fresh example and just get working to show everything needed - we can chat about merging it in after if desired. These changes + my upcoming ones should take care of both VK_NV_ray_tracing and VK_EXT_descriptor_indexing from #178 Co-authored-by: Graham Wihlidal <graham@wihlidal.ca>
This PR adds support for VK_NV_ray_tracing! (and initial support for VK_EXT_descriptor_indexing, but more support coming for that).
One piece I'm unsure if you have a more suggested approach is what I added to ext/mod.rs for names (both of those extensions are very commonly used, and also required for ray tracing). Maybe there should be a names.rs or something which can implement a static string function for all names that don't warrant their own extension struct?
I have a local example I've been working on that has been testing against this code, as well as support for descriptor indexing. Originally, I was adding an nv_ray_tracing.rs example alongside triangle and texture, but ray tracing requires some specific extensions and also it doesn't need frame bindings, render states, etc. Additionally, this example only works on NV and with a Turing-class GPU, so I'm unsure if it should co-exist with the basic examples? Because of this, I'm going to first start with a fresh example and just get working to show everything needed - we can chat about merging it in after if desired.
These changes + my upcoming ones should take care of both VK_NV_ray_tracing and VK_EXT_descriptor_indexing from #178