Skip to content

Conversation

@jsw800
Copy link
Contributor

@jsw800 jsw800 commented Nov 20, 2025

My team uses the Tsvector type, and we're trying to start using generators in tests, but tsvector currently doesn't have a generator so trying to generate something with it raises. This adds one that just always creates an empty list. I'm open to suggestions if you think the generator should be doing something more complex here—I assume this is a scenario where, if someone wants to be generating something specific for it in a test, they probably have a clear idea of what that is.

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

Copy link
Contributor

@zachdaniel zachdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reasonable for now, doesn't hurt, but we may eventually want to figure out some way to do it in a more realistic way etc.

@zachdaniel zachdaniel merged commit d19d4ce into ash-project:main Nov 21, 2025
64 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants