Add GrapeLogging::Formatters::Rails. Updates to README #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveharris
changed the title
|
@daveharris great addition and thanks for the output documentation for other formatters 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aserafin I added this Formatter to get a line like the last line in a standard Rails app:
Rails:
After this change with
formatter: GrapeLogging::Formatters::Rails.new:I haven't found a way to determine the installed ORM so I had to change
ActiveRecordtoDB.I also cleaned up the README giving examples of each formatter and added some specs for my new formatter.
I have tested it in a real-life Rails+Grape app and works great.
I haven't submitted a PR before so let me know if there is anything else I need to do.
Thanks for the gem!