port deep parameter logging from Badiapp/grape_logging #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aserafin Is there any chance of getting this PR merged and a new gem built? |
aserafin
requested changes
Mar 1, 2017
| def safe_parameters(request) | ||
| # Now this logger can work also over Rails requests | ||
| return clean_parameters(request.env[AD_PARAMS] || {}) if request.params.empty? | ||
| clean_parameters(request.params.clone) |
There was a problem hiding this comment.
looking at ParameterFilter class I don't think we need to clone parameters anymore, right?
There was a problem hiding this comment.
could we also do if ... else ... end here?
|
hey @jason-uh - sorry it took so long and thanks for contribution, especially the tests 💪 could you take a look at two notes I left? |
aserafin
approved these changes
Mar 6, 2017
|
Thanks @aserafin. |
|
@aserafin would you also publish a new version of the gem? Thanks. |
|
Awesome @aserafin. Thanks a bunch, and thanks to @oricodes89 from @Badiapp for the initial code. |
|
Thanks to @dsantosmerino! @Badiapp is happy to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports deep parameter logging from Badiapp/grape_logging without having to depend upon Rails directly (lifts the
ParameterFilterfrom Rails, or uses it indirectly if Rails is available). I also started to add some specs.