Skip to content

feat: log failure to add plugin in "plugin test" #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tbobm
Copy link

@tbobm tbobm commented Apr 8, 2025

Summary

Display the internal reason why the plugin failed to be installed.

Error are currently returned but unused and there are several reasons why the plugin addition could fail

Current:

$ go run cmd/asdf/main.go plugin test my-plugin some-url install 1.1.1
FAILED: my-plugin was not properly installed
exit status 1

With changes:

$ go run cmd/asdf/main.go plugin test my-plugin some-url install 1.1.1
FAILED: my-plugin was not properly installed reason: Plugin named asdf-test-my-plugin already added
exit status 1

Signed-off-by: Theo Bob Massard <tbobm@protonmail.com>
@tbobm tbobm requested a review from a team as a code owner April 8, 2025 11:04
@tbobm tbobm changed the title Log failure to add plugin in "plugin test" feat: log failure to add plugin in "plugin test" Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant