fix!: Be aware of ForcePrepend
#2028
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machupicchubeta
force-pushed
the
be_aware_of_force_prepend
branch
2 times, most recently
from
32bab49 to
137b35f
Compare
Previously, the value of `ForcePrepend` was not used anywhere and was not behaving as specified. With this commit, the behavior will be as specified. BREAKING CHANGE: So far, `ASDF_FORCE_PREPEND` environment variable setting has been ignored, but this commit may change the behavior depending on the setting. If it is not set, macOS behavior will not change, but Linux behavior will change. If you want to get the same behavior as before, it is recommended to set the relevant environment variable. Referenced Documents: - https://github.com/asdf-vm/asdf/blob/932ac468b7c24c2adef90a293a1f7280a0074cc4/docs/manage/configuration.md#asdf_force_prepend Background: @andrecloutier told about this issue me in a comment on another PullRequest. Thank you! - asdf-vm#2011 (comment)
machupicchubeta
force-pushed
the
be_aware_of_force_prepend
branch
from
5e0609e to
f9bf8fb
Compare
machupicchubeta
changed the title
ForcePrependForcePrepend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the value of
ForcePrependwas not used anywhere and was not behaving as specified.With this commit, the behavior will be as specified.
BREAKING CHANGE
So far,
ASDF_FORCE_PREPENDenvironment variable setting has been ignored, but this commit may change the behavior depending on the setting.If it is not set, macOS behavior will not change, but Linux behavior will change.
If you want to get the same behavior as before, it is recommended to set the relevant environment variable.
Other Information
Referenced Documents
Background
@andrecloutier told about this issue me in a comment on another PullRequest. Thank you!
ASDF_FORCE_PREPENDenvironment variable #2011 (comment)