Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for
~
provided via env vars. Also removesgo-homedir
directly and indirectly via revive. While we could argue setting~
in the environment is invalid, it's also a simple error to make (ASDF_DATA_DIR=~/.asdf
vsASDF_DATA_DIR="~/.asdf"
). Since this code already handles parsing~
out of the default values, it's not hard to handle the user provided case by moving the replacement a few lines down.Fixes: #1997
Fixes: #1923
Other Information
Before
After