Skip to content

fix: handle tilde in env vars #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

andrecloutier
Copy link
Contributor

@andrecloutier andrecloutier commented Mar 5, 2025

Summary

Adds support for ~ provided via env vars. Also removes go-homedir directly and indirectly via revive. While we could argue setting ~ in the environment is invalid, it's also a simple error to make (ASDF_DATA_DIR=~/.asdf vs ASDF_DATA_DIR="~/.asdf"). Since this code already handles parsing ~ out of the default values, it's not hard to handle the user provided case by moving the replacement a few lines down.

Fixes: #1997
Fixes: #1923

Other Information

Before

andre@Andres-MacBook-Pro asdf % ASDF_DATA_DIR="~/.asdf" asdf info 
OS:
Darwin Andres-MacBook-Pro.local 24.3.0 Darwin Kernel Version 24.3.0: Thu Jan  2 20:24:22 PST 2025; root:xnu-11215.81.4~3/RELEASE_ARM64_T6041 arm64

SHELL:
zsh 5.9 (arm64-apple-darwin24.0)

BASH VERSION:
3.2.57(1)-release

ASDF VERSION:
0.16.4

ASDF INTERNAL VARIABLES:
ASDF_DEFAULT_TOOL_VERSIONS_FILENAME=.tool-versions
ASDF_DATA_DIR=~/.asdf
ASDF_CONFIG_FILE=/Users/andre/.asdfrc

ASDF INSTALLED PLUGINS:

After

andre@Andres-MacBook-Pro asdf % ASDF_DATA_DIR="~/.asdf" ./asdf info
OS:
Darwin Andres-MacBook-Pro.local 24.3.0 Darwin Kernel Version 24.3.0: Thu Jan  2 20:24:22 PST 2025; root:xnu-11215.81.4~3/RELEASE_ARM64_T6041 arm64

SHELL:
zsh 5.9 (arm64-apple-darwin24.0)

BASH VERSION:
3.2.57(1)-release

ASDF VERSION:
"1391473-dev"

ASDF INTERNAL VARIABLES:
ASDF_DEFAULT_TOOL_VERSIONS_FILENAME=.tool-versions
ASDF_DATA_DIR=/Users/andre/.asdf
ASDF_CONFIG_FILE=/Users/andre/.asdfrc

ASDF INSTALLED PLUGINS:
bats       https://github.com/timgluz/asdf-bats.git          299551f1668b2ba11804bdca709da8933b647bb5
elixir     https://github.com/asdf-vm/asdf-elixir.git        ea842831ae39417f2dfe7b96fb0c3cc573314aa6
erlang     https://github.com/asdf-vm/asdf-erlang.git        0e617b61ece7cff73331aacc1cd9986e35618c41
go-sdk     https://github.com/yacchi/asdf-go-sdk.git         3d336a3b582ecb0e3d9337b78581bb8a955352dd

@andrecloutier andrecloutier marked this pull request as ready for review March 5, 2025 03:18
@andrecloutier andrecloutier requested a review from a team as a code owner March 5, 2025 03:18
@andrecloutier andrecloutier changed the title fix: support tilde in env vars fix: handle tilde in env vars Mar 5, 2025
@andrecloutier andrecloutier force-pushed the fix_tilde_parsing branch 3 times, most recently from 1771322 to 38a341a Compare March 5, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant