-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(master): release 0.13.0 #1580
Conversation
This change was the first to occur before any other changes after the last release. It caused Release Please to create a patch-level release. This was not expected. I think it is a bug in Release-Please. asdf/.github/workflows/release.yml Line 21 in 5133819
Configuration to show Related googleapis/release-please#1745 |
954c807
to
cb8285a
Compare
I was thinking the next release (bugfix release) could be done after the following are merged or resolved:
Thoughts?
In the next feature release, I was hoping to implement #1579 (which is a breaking change) and #1599, which is why I wanted to get these bug fixes out of the way. |
As a sort of side-note, I was wondering if asdf currently has a general stance on maintainership or if current maintainers were open to adding one? I was thinking it would be quiet useful if I had the ability to add/remove tags from issues, enable running workflows, merge other people's PRs, etc. the usual stuff. I know ya'll maintainers are pretty busy, so I'm hoping the extra help could be useful. I've been contributing stuff for some time now, so I hope this ask isn't out of the blue or something. 😅 |
@jthegedus @Stratus3D I am sorry for pinging, but when one (or both) of you have the time, I would really appreciate a comment. Looking to get out a bugfix (and #1579) out sooner rather than later. |
cb8285a
to
8d49295
Compare
@hyperupcall Sorry mate, have been afk from OSS the past few weeks. Back at it though! I will review most of these over the coming days. |
adc7653
to
eaa336f
Compare
@jthegedus I understand, it can be difficult finding time for open source - you'll get to them when you get to them. If you feel comfortable adding me as a maintainer, I would be happy to help review others' PRs like I mentioned before. Also I know I'm a week late in responding and you are still busy, so I just wanted be explicit and say I'm not trying to be passive-aggressive with the timing of my response and everything I said was genuine. |
eaa336f
to
c7c7603
Compare
a6c3bb1
to
580b731
Compare
580b731
to
d522c44
Compare
Adding you as a maintainer is something I've been thinking about for some time and will definitely discuss with @Stratus3D about very soon. Again, sorry for the delays here. Your help has been greatly appreciated as has your patience 😃 |
Going to finally cut this release 😅 |
🤖 Release is at https://github.com/asdf-vm/asdf/releases/tag/v0.13.0 🌻 |
🤖 I have created a release beep boop
0.13.0 (2023-09-11)
⚠ BREAKING CHANGES
plugin list
exit code 0 when no plugins are installed (#1597)Features
Patches
plugin list
exit code 0 when no plugins are installed (#1597) (a029c00)Documentation
bin/latest-stable
empty query is set to default (#1591) (299dc97)This PR was generated with Release Please. See documentation.