Prefer asdf when searching for an installed version of npm#426
Merged
augustobmoura merged 2 commits intoasdf-vm:masterfrom Jun 18, 2025
Merged
Prefer asdf when searching for an installed version of npm#426augustobmoura merged 2 commits intoasdf-vm:masterfrom
augustobmoura merged 2 commits intoasdf-vm:masterfrom
Conversation
Member
|
It is a fix but it should be a temporary one, the real problem is probably on asdf-core. I'm merging this to unblock other people, but I plan on revising this approach when I get the time. Thanks for looking into this @anup-the-magic! This will help tremendously in the mean time |
This was referenced Jun 18, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is a fix to the NPM detection flow, which prefers the currently selected,
asdf-installed version of NPM over some other, globally installed version of NPM.Context, I have
asdfinstalled on Ubuntu under WSL2, and I have global installation of NPM in Windows. WSL2 adds my Windows path to$PATH, but I don't wantasdfto detect that when selecting a version of node, so I'd rather bias it to the one selected viaasdf where nodejs. This might fix the longstanding #271, but that's seen zero activity in 4 years, so I don't even know if that's still an issue.